search

jejacks0n / mercury

Mercury Editor: The Rails WYSIWYG editor that allows embedding full page editing capabilities directly inline.
http://jejacks0n.github.com/mercury
Other
2.63k stars 530 forks source link

jQuery 1.8 window size bug #313

Closed kieranklaassen closed 11 years ago

kieranklaassen commented 11 years ago

With jQuery 1.8 the iframe window is a wrong size and the link dialog also. See a project that demonstartes this here:

https://github.com/kieranklaassen/mercury_window_bug

Just go to: http://localhost:3000/editor

hodosan commented 11 years ago

Recently i update rails 3.2.6 to 3.2.11. i received wrong size of iframe window too. simply i backed jquery-rails 2.1.14 to 2.0.2. then it seems to work correctly.

hayesr commented 11 years ago

For the to get the iframe to fill the page I added:

iframe{
  height: 100%;
  margin-top: 80px;
}

to mercury_overrides.css in my app. (this might need to be more specific for other cases)

I think there may be a related problem with modal rendering. I'm getting the following behavior in Chrome 21: Screen Shot 2013-01-25 at 5 39 34 PM

Resizing the window makes the modal display correctly.

Can anyone else attest to this?

Although I'm sure going back a version with jQuery works, I'm investigating whether something can be changed in the way modals are initialized to work around whatever changed in jQuery.