search

jejacks0n / mercury

Mercury Editor: The Rails WYSIWYG editor that allows embedding full page editing capabilities directly inline.
http://jejacks0n.github.com/mercury
Other
2.63k stars 530 forks source link

Overline Style toggle button is not shutting off #357

Closed mkralla11 closed 11 years ago

mkralla11 commented 11 years ago

The issue I am facing is that the Overline toggle button turns on correctly, but will not turn off. First step I took in troubleshooting is that after typing some text with the Overline toggle button on, I then turn it off, type some more text, and then check what actual html is being generated in the markup editor.

I can gaurentee that this is NOT an implementation issue, because I verified this problem happening on the demo page for the editor as well. here is the html that is generated on the demo page, after simply typing the phrase 'this should be on' with the Overline button on, then toggling it off, and typing the phrase 'this should be off':

Mercury is a full featured HTML5 editor. It was built from the ground up to help your team get the most out of content editing in modern browsers. This is on This is off

As you can see, the phrase 'this should be off' becomes nested within another span tag with the overline style, rather than just closing off the first span after toggling off.

I hope I've explained this well, and if not, let me know and I will do my best to re-word it.

This is verified in Firefox 19.0.2 and Safari 6.0.2 on the DEMO page.

jejacks0n commented 11 years ago

Yeah, it's a known issue.. the new version removes overline -- are you even using it?

mkralla11 commented 11 years ago

I'm assuming the new version isn't being used on the demo page?

jejacks0n commented 11 years ago

Correct -- the new version isn't even done yet. =) Check the developer notice in the readme.

dedico commented 11 years ago

@jejacks0n Hi, could you please let us know what is your timeline to get the new version ready to try?

Or it is possible to use it right now? With Rails?

Thanks, Marek