search

jejacks0n / teaspoon

Teaspoon: Javascript test runner for Rails. Use Selenium, BrowserStack, or PhantomJS.
1.43k stars 243 forks source link

add ability to set spec_timeout for phantomjs #108

Closed tmandke closed 10 years ago

jedschneider commented 11 years ago

Is the primary purpose of this to help CI bail out of a bad run? Are there other use cases I'm missing?

jejacks0n commented 11 years ago

I initially hardcoded this value to three minutes (180 seconds I think), but there are some scenarios where Phantom doesn't receive an error and doesn't begin execution (these are rare, but can happen). I added the timeout so in those cases it will only sit there for 3 minutes before registering it as an error.

It's likely this is to enable longer running tests. I remember adding a todo (https://github.com/modeset/teaspoon/blob/master/lib/teaspoon/drivers/phantomjs/runner.coffee#L8)

So this completes that todo. =)

@tmandke, if you could remove that todo line I'll merge.

:+1:

jejacks0n commented 11 years ago

Can you merge master and force push this branch so I can merge this in?

jejacks0n commented 10 years ago

Hey, this is a follow up.. do you want to merge master so I can merge this nicely?

jejacks0n commented 10 years ago

I'm going to close this and implement something similar. Thanks for the pull request, and sorry I wasn't able to utilize it.