search

jejacks0n / teaspoon

Teaspoon: Javascript test runner for Rails. Use Selenium, BrowserStack, or PhantomJS.
1.43k stars 243 forks source link

updated README to reflect that jasmine supports skipping tests #111

Closed martco closed 11 years ago

martco commented 11 years ago

http://pivotal.github.io/jasmine/\#section-Disabling_Specs_and_Suites

jejacks0n commented 11 years ago

There's two states, and I think you're missing one. There is skipped (I don't care about it) and pending (I need to see this so I don't forget).

You're right, jasmine allows skipping tests. It doesn't allow pending, so we did in fact add the support. Do you have info I don't have?

martco commented 11 years ago

You're right I missed a state. I don't have info you don't have. Feel free to reject with furious anger.

jejacks0n commented 11 years ago

Haha, no worries.. I think there were two lines, and they can be found here: https://github.com/modeset/teaspoon/blob/master/vendor/assets/javascripts/jasmine-1.3.1.js#L868

This lets the reporter understand that it wasn't skipped, but there was no function to execute there, thus no assertions.