search

jejacks0n / teaspoon

Teaspoon: Javascript test runner for Rails. Use Selenium, BrowserStack, or PhantomJS.
1.43k stars 243 forks source link

Fixes problems running all tests after success #173

Closed chrisnicola closed 10 years ago

chrisnicola commented 10 years ago

This allows the console runner to work with guard-teaspoon to allow for all tests to be re-run after a previously failing set of tests passes. I'm still not that familiar with how this was designed so I'm hoping if done the right things here.

One thing I noticed was that it's hard for me to be sure what the intentions for various instance variables used for things like "suites", "files and "options" are. As a result I don't want to make any more changes than necessary here though, but I'd be happy to discuss how this might be made simpler and work on some more contributions to improve the integration between this and guard further.

This helps to fix https://github.com/modeset/guard-teaspoon/issues/3

jejacks0n commented 10 years ago

I'm redoing a major portion of this, and would love you to jump in and contribute to this if you'd like. I won't merge this as I think it may only confuse matters, but I've been working to create a better api for teaspoon, which will make guard-teaspoon much easier to implement, and may make it a little more clear.

Let me know if you'd like to be involved in this and I can grant commit privs to teaspoon and guard-teaspoon after a short conversation.

chrisnicola commented 10 years ago

Thanks @jejacks0n I saw your branch and I'm going to try to put aside some time to look at it.