search

jejacks0n / teaspoon

Teaspoon: Javascript test runner for Rails. Use Selenium, BrowserStack, or PhantomJS.
1.43k stars 243 forks source link

Route problem in rails 4 #174

Closed OpakAlex closed 10 years ago

OpakAlex commented 10 years ago

http://localhost:3001/teaspoon/default/?file=%2Fprivate%2Fvar%2Fwww%2Fapi-hogs%2Fmapidy%2Ftest%2Fjavascripts%2Fintegration%2Fgroups%2Findex_test.coffee

Then I have this: https://www.monosnap.com/image/TqIAgXQ2GmgocPIJWZMKXEr9na2pJu

jejacks0n commented 10 years ago

I'm using it rails 4 and it works fine. Can I see your gemfile?

jejacks0n commented 10 years ago

It could be the last slash? Where did you get the URL from?

OpakAlex commented 10 years ago

Yes, problem in last slash. Url is: image

jejacks0n commented 10 years ago

Then I don't understand.. If you look, I'm testing against rails 4.0.0 (https://github.com/modeset/teaspoon/blob/master/Gemfile#L11), and just updated locally to rails 4.0.2, and everything continues to work fine.. there's something conflicting with it, or a rails config that I'm unaware of... I don't know, but it works for everybody that I'm aware of, so I'd encourage you to identify it -- as I can't fix it if I can't reproduce it.

OpakAlex commented 10 years ago

I am using Rails from master:

remote: git://github.com/rails/rails.git
  revision: e66c148571ff86144e49f23c43e5dd686e67da29
jejacks0n commented 10 years ago

I can reproduce it.. but it seems like a regression in rails, no?

I've since removed it, but it's in the non-existent teaspoon 0.8 branch (I haven't pushed it yet).

https://github.com/modeset/teaspoon/blob/master/lib/teaspoon/suite.rb#L69

Can you find any documentation change that would explain why that route behavior would change? And if not, do you want to open an issue on Rails? Seems odd that a route that works in major releases (and a relatively common thing to do) should break on master.

OpakAlex commented 10 years ago

I will up rails and test for it. I think now it's issue has been fixed.