[requirejs] fix html_safe method inside boot

jejacks0n / teaspoon

Teaspoon: Javascript test runner for Rails. Use Selenium, BrowserStack, or PhantomJS.

1.43k stars 243 forks source link

[requirejs] fix html_safe method inside boot #188

Closed rafalbromirski closed 10 years ago

rafalbromirski commented 10 years ago

I've noticed typo mistake in _boot_require_js.html.erb file. It was htm_safe instead of html_safe.

coveralls commented 10 years ago

Coverage remained the same when pulling b158574a65a0f459886f948c12bd7b60b4135a37 on paranoida:fix-boot-require-js into 268c00fa37e058a4bcf3e917f1a128a3bdb991c2 on modeset:master.

jejacks0n commented 10 years ago

Thanks. I was hoping someone would check this out and resolve anything outstanding.

jejacks0n commented 10 years ago

I personally don't want to maintain two different structures, which requirejs needs to function. It's on the todo list to get proper specs for this in place so we can avoid breaking it in the future, so if you want to be an awesome open source contributor, you're welcome to add that. =) It would be appreciated.

rafalbromirski commented 10 years ago

yeah, I know your pain. Right now I'm trying to migrate from jasminerice to teaspoon. It's not ready yet (still have a few issues with my requirejs & test setup) but if I find something that I can improve then I will create PR.

jejacks0n commented 10 years ago

Appreciate it. Hopefully you came across the wiki page.

rafalbromirski commented 10 years ago

I already did it :) thx