Fixes for Guard again - Githubissues

jejacks0n / teaspoon

Teaspoon: Javascript test runner for Rails. Use Selenium, BrowserStack, or PhantomJS.

1.43k stars 243 forks source link

Fixes for Guard again #190

Closed chrisnicola closed 10 years ago

chrisnicola commented 10 years ago

Fixes @options holding the merged values from previous calls to #execute. This allows the proper behaviour for re-running all specs after a pass.

I've managed to fix all the failing specs but for one on the coverage_specs where I'm unsure of the cause.

chrisnicola commented 10 years ago

Seems to be another problem, not sure if I should fix it here. If the runner throws an exception for any reason (e.g. syntax error in coffeescript) it will exit and Guard can't continue to run. A few ways we could deal with this.

Guard-Teaspoon should spawn a new console for each run (problem is that's a new server each time too.
Guard-Teaspoon shouldn't use the console runner at all.
Teaspoon console shouldn't exit on these errors.

jejacks0n commented 10 years ago

Cool, you want to create issues with an explanation and use case so I can understand what you want fixed. it makes it easier and requires less time dedication to sort out what's going on. =) I can then focus more on making it work the way it's expected.

chrisnicola commented 10 years ago

I'll add a commit to this PR showing you the fix and you can decide from there.