search

jejacks0n / teaspoon

Teaspoon: Javascript test runner for Rails. Use Selenium, BrowserStack, or PhantomJS.
1.43k stars 243 forks source link

Cross-Platform which method do not return a directory as valid result #195

Closed yannlugrin closed 10 years ago

yannlugrin commented 10 years ago

File.executable? can return true if is a directory, just verify if is a file before test is is executable.

Problem spotted on OSX (Montain Lion) with ruby 2.0.0-p247

jejacks0n commented 10 years ago

Thanks!

jejacks0n commented 10 years ago

Aww, can't merge from my phone when the build is failing. I'll merge it in a bit.