Prevent early exit after an error

jejacks0n / teaspoon

Teaspoon: Javascript test runner for Rails. Use Selenium, BrowserStack, or PhantomJS.

1.43k stars 243 forks source link

Prevent early exit after an error #263

Closed aasmith closed 9 years ago

aasmith commented 10 years ago

Use the provided timeout to give the runtime longer before quitting after an error.

This fixes a problem where we were seeing a non-fatal parse error prevent our test suite from running.

The error sets a one second timer, during which time, if there are no calls to console.log, then a fatal error is assumed. Making this timeout tunable gives us some leeway in troubleshooting.

coveralls commented 10 years ago

Coverage remained the same when pulling c0006cc1bbb14f4ca76e76e424381f7cc820c15d on aasmith:master into 592c0dba4c1131f0107f773b483079cda61f5b06 on modeset:master.

jejacks0n commented 9 years ago

since I couldn't easily merge this, and it was a simple change I've made the change and will see where net out. thanks.