Closed stevenmichaelthomas closed 10 years ago
Nice! Will merge if you update the README and the install generators -- specifically the teaspoon_env stuff. Thanks.
@jejacks0n That's great news! I'll finish things off tomorrow morning.
I added the version number to the filename, updated the readme, and updated comments in mocha's spec_helpers (js and coffee). Didn't see any teaspoon_env stuff that needed updating in this case.
Thanks again.
@jejacks0n good to merge?
Yes, almost. =)
Will you do an interactive rebase to get it into one commit? It's easier to track what changed in regards to that if it's in one commit.
git rebase -i HEAD~3 pick the first one, change the other two commits from pick to s (to squash) then adjust the commit message in the second step git push -f origin [branch_name]
Also, if you've never done one, it's worth learning. =)
I'm a big fan of squashing things down as much as possible :) will take care of this shortly. Thanks again!
On Fri, Sep 19, 2014 at 9:52 PM, Jeremy Jackson notifications@github.com wrote:
Yes, almost. =) Will you do an interactive rebase to get it into one commit? It's easier to track what changed in regards to that if it's in one commit. git rebase -i HEAD~3 pick the first one, change the other two commits from pick to s (to squash) then adjust the commit message in the second step git push -f origin [branch_name]
Also, if you've never done one, it's worth learning. =)
Reply to this email directly or view it on GitHub: https://github.com/modeset/teaspoon/pull/266#issuecomment-56253680
Thank you!
I understand not wanting to bloat the support libraries, but I believe chai-jq is a great addition to a mocha test framework, in the same way that Jasmine-jQuery is to the Jasmine stream of things.
chai-jq well-maintained and thoroughly tested.
Would be great to have this available as an option if you think it fits within the greater context of this project.
Thanks!
/cc @ryan-roemer