search

jejacks0n / teaspoon

Teaspoon: Javascript test runner for Rails. Use Selenium, BrowserStack, or PhantomJS.
1.43k stars 243 forks source link

Add capybara-webkit driver #280

Closed brysgo closed 9 years ago

brysgo commented 9 years ago

Yes, I know its a bit of a quick solution, and yes, I get a little hacky with the tests. Don't judge me :-p

I'm hoping there is a chance this won't hang on CircleCI like phantom is.

Happy to take suggestions if you have any.

coveralls commented 9 years ago

Coverage Status

Coverage decreased (-0.61%) when pulling 005e165aaa045f1cffb3328c9c158c61c65a152a on brysgo:capybara-webkit-driver into 32d3385042f2c5295e8f74955559e29c155b93e5 on modeset:master.

brysgo commented 9 years ago

Actually, you can judge me. I didn't realize that you were using capybara elsewhere so stubbing out the session probably wasn't the best idea.

jejacks0n commented 9 years ago

https://github.com/modeset/teaspoon/wiki/Using-Selenium-WebDriver

jejacks0n commented 9 years ago

I'm not opposed to this at all, but I don't know if I follow.

jejacks0n commented 9 years ago

The reason I put in selenium was because it's about as broad of support as you could ask for. You can use it with safari, or IE, though I can't imagine the setup for IE is anything easy.

brysgo commented 9 years ago

The reason for this is simply that phantom is hanging our test suite and selenium is much slower. So this is an alternative that I'm hoping won't hang on our CI server.

I will resubmit this when I figure out a way to make my tests play nice with the capybara sweet in this project.