jejacks0n / teaspoon

Teaspoon: Javascript test runner for Rails. Use Selenium, BrowserStack, or PhantomJS.
1.43k stars 243 forks source link

Add configuration which allows you to disable expansion of assets #296

Closed bramski closed 9 years ago

bramski commented 9 years ago

This adds a configuration variable so that you can disable expansion of assets. This fixes issue:

https://github.com/modeset/teaspoon/issues/292

By allowing you to configure and turn off asset expansion.

coveralls commented 9 years ago

Coverage Status

Coverage remained the same at 99.05% when pulling ea12f3c8e2967d4ca9ceb728e455c81d713da0b3 on bramski:speed-improvements into 83440f080185d495e48dfc35420cffeb8596c7b1 on modeset:master.

bramski commented 9 years ago

Can any of the contributors tell me what's going on with tests in this project?

jejacks0n commented 9 years ago

They're failing because of updates to dependencies. Thanks for this PR, I'll review and merge when I get some time.

bramski commented 9 years ago

Poke.

jejacks0n commented 9 years ago

Can you provide documentation updates -- and an option to override/provide the option from the command line interface?

jejacks0n commented 9 years ago

Poke -- You should be good to get this rebased and the specs should pass. Still just waiting for the configuration option to be fully baked into the project.

mikepack commented 9 years ago

Closing and moving discussion to #318

bramski commented 9 years ago

Cool. Haven't had many cycles to get back to this recently, thanks for picking up the torch.