search

jejacks0n / teaspoon

Teaspoon: Javascript test runner for Rails. Use Selenium, BrowserStack, or PhantomJS.
1.43k stars 243 forks source link

move the default position of the require comment to the top. #310

Closed igwan closed 9 years ago

igwan commented 9 years ago

I just fell into the catch described by kareemamin here https://github.com/modeset/teaspoon/issues/301. I looked for error elsewhere in my code for way to long, not realizing the require position was the problem. So here is a PR.

coveralls commented 9 years ago

Coverage Status

Coverage remained the same at 99.54% when pulling 937487953f5cdeb8f44609c5a5ba09098ca49e0e on igwan:fix-require-application-comment-position into 84441c8ba42488ffe47b7e99833c38c3c8f71449 on modeset:master.

jejacks0n commented 9 years ago

Thanks, but please adjust this to only shift the application require to not be above any dependency loads.. you've put it above the bind-poly in some cases, and it should not be above any other dependency.

coveralls commented 9 years ago

Coverage Status

Coverage remained the same at 99.54% when pulling 033bd0f2576d1171a623bbb85c603e0527b6edca on igwan:fix-require-application-comment-position into 84441c8ba42488ffe47b7e99833c38c3c8f71449 on modeset:master.