Add responder to handle hooks in one place

jejacks0n / teaspoon

Teaspoon: Javascript test runner for Rails. Use Selenium, BrowserStack, or PhantomJS.

1.43k stars 243 forks source link

Add responder to handle hooks in one place #328

Closed mikepack closed 9 years ago

mikepack commented 9 years ago

This adds the responder abstraction between the reporter and the framework. This accomplishes the following:

Give a clear place to see how Teaspoon hooks into a framework
DRY up the console and HTML reporters so they don't both have to provide framework hooks

jejacks0n commented 9 years ago

:+1: This looks good, but I'm going to have many conflicts with this one.

jejacks0n commented 9 years ago

You want to hold off with doing this for all frameworks while I finish tidying up #321?

mikepack commented 9 years ago

Cool, thanks for the quick review. I'll hold off or I can branch off your branch. Cool to merge this though?

jejacks0n commented 9 years ago

Yeah, let's do it, I'll rebase again and then get #321 in shortly there after. Then we should be in a good place to move forwards. I've been spending some time here and there figuring out how best to make specs easier within the framework gems, but I have yet to figure out how to get bundler to install the development dependencies for a gem, and thus, can't quite get it working smoothly.

mikepack commented 9 years ago

Got it. I'm happy to review #321 as soon as you feel comfortable or just ping me if you want any input/help.

jejacks0n commented 9 years ago

cool, I'm on gitter if you want to chat more real time.. I'm finishing up a few things right now.