Do not double load teaspoon_env

jejacks0n / teaspoon

Teaspoon: Javascript test runner for Rails. Use Selenium, BrowserStack, or PhantomJS.

1.43k stars 243 forks source link

Do not double load teaspoon_env #340

Closed mikepack closed 9 years ago

mikepack commented 9 years ago

When loading from the console, we need to load the Rails env, so we load the app's teaspoon_env. When we load teaspoon_env, the app then loads all engines, including teaspoon. Previously, this double loaded teaspoon_env and caused multiplicative effects on configurations that accumulate values, like #hooks.
Updates the predicate method rails_loaded? to always return a boolean

Fixes #332

jejacks0n commented 9 years ago

:+1: The only thing I'm so-so on is the class << self -- reason being it's more difficult in terms of readability to someone not super experienced in ruby. Up to you on if you want to change it though.

Nice work!

mikepack commented 9 years ago

Word. I'll change that and merge.

jejacks0n commented 9 years ago

@mikepack I honestly don't mind it, that was just feedback.

mikepack commented 9 years ago

It sounds like you really hate it, so I'm going to remove it and never do it in the future. :trollface:

jejacks0n commented 9 years ago

haha

mikepack commented 9 years ago

FYI, couldn't completely remove class << self as it's the only want to define an attr_accessor on a module.

jejacks0n commented 9 years ago

Fair enough. Somewhat related, we should move away from active_support as we go too. Feel free to do that in other PRs.