Closed mikepack closed 9 years ago
Redundant curly braces around a hash parameter.
Looks good aside from that.
We should also consider adding a notice in the deprecation saying that no_coverage
no longer works, with instructions on how to get the same behavior.
@davestevens Teaspoon 1.0 (unreleased) should fix your issue with RequireJS #322
Since RequireJS does not use sprockets to require assets, 4ed7fbd was added to put instrumentation on all assets if coverage is requested.
suite.no_coverage
(removed) was used to exclude files from instrumentation as they are compiled insuite.spec_assets
and included on the page for testing. Sincesuite.no_coverage
was only being referenced when requiring assets from sprockets, it had no affect on people using RequireJS. #322 was proposed to ignore files for the case of RequireJS. This is a more formal stab at the same idea.Upgrade notes
Anyone doing:
Should now do: