search

jejacks0n / teaspoon

Teaspoon: Javascript test runner for Rails. Use Selenium, BrowserStack, or PhantomJS.
1.43k stars 243 forks source link

Redesign #376

Closed rstacruz closed 9 years ago

rstacruz commented 9 years ago

Would you guys be interested in a newer look for Teaspoon?

mikepack commented 9 years ago

Dig it. I wouldn't mind an updated look. @jejacks0n, what do you think?

jejacks0n commented 9 years ago

Looks good, but let me think on it. Here's my train of thought thus far... Initially I thought it's too white, and I don't like the large margins unless they do something nice at lower resolutions.

I often run teaspoon with the dev tab to the right, and the margins just eat into space that's useful. But on the other hand, it kinda grows on me, so I can't decide just yet. I'm unsure what the [?] is at the bottom as well -- can you explain?

jejacks0n commented 9 years ago

Oh, I'd also need to see the alternate views (only failures), and results for pending and failures when the full report is generated.

rstacruz commented 9 years ago

The (?) at the bottom is just an artifact of our project's build... that's Intercom.io's button somehow making its way to our teaspoon tests haha.

of course the margins are collapsible... shouldn't be hard to make it responsive. btw, isn't the large "Teaspoon" text extraneous at this point?

rstacruz commented 9 years ago

there's a lot of work to get this working btw... CSS is the easy part, but the canvas progress bar would have to be modified a lot to make it render a simpler graph.

(actually, i'm pretty confident it can be implemented without canvas... just plain CSS.)

btw, for reference, this is how Mocha looks like on its default HTML reporter: demo

jejacks0n commented 9 years ago

Yeah, the code to accomplish what I wanted in css was uglier than the canvas approach (a simpler design would fix that, but not as is). If you want to design it, and provide the things outlined, I'm happy to consider and potentially implement it with potential adjustments.

mikepack commented 9 years ago

Going to close for now, but would love to see progress on this in the form of a PR.