search

jejacks0n / teaspoon

Teaspoon: Javascript test runner for Rails. Use Selenium, BrowserStack, or PhantomJS.
1.43k stars 243 forks source link

Favicon is being requested and not needed. #377

Closed jejacks0n closed 8 years ago

jejacks0n commented 9 years ago

So, somebody brought this up a bit ago, and I thought it was a cool idea. First, the favicon is being requested when it's not needed. If you don't have one, you see a 500 or 404.

As a first pass we should at least disable that request.

<link rel="shortcut icon" href="data:image/x-icon;," type="image/x-icon">

And as a follow up, we could put a little blue -> red or green favicon as the tests run and complete.

mikepack commented 9 years ago

I like the changing favicon idea. Can we use the svgs we have to create the icons?

jejacks0n commented 9 years ago

I think we can just swap out that href with a base64 encoded url.. though, favicons are cached heavily, but that's where we can start. Do you want me to look at it, or is it something that interests you?

mikepack commented 9 years ago

If you could look into that, it would be awesome. You seem to have a strong grasp on how to accomplish it.

jejacks0n commented 9 years ago

I'll actually look into this tomorrow.

jejacks0n commented 8 years ago

I clearly never looked into this, so I'm going to sweep this failure under the rug. ;-P