jejacks0n / teaspoon

Teaspoon: Javascript test runner for Rails. Use Selenium, BrowserStack, or PhantomJS.
1.43k stars 243 forks source link

Total test count is not set for reports #378

Closed crgee closed 9 years ago

crgee commented 9 years ago

For Version 1.0.2 the total test count is blank on each report.

We came across this when our TAP reader failed to parse a report. In our particular case all tests are passing and there is no console output to influence parsing. I double checked the issue by confirming the value was missing from multiple formats:

This seems to be due to the report total not being set upstream from this point. (Probably an obvious point, but I figured any help would be beneficial, and I am out of time myself. :sweat:)

Thanks, and fantastic work on the latest releases - cleaned up our infrastructure greatly.

mikepack commented 9 years ago

Thanks for the report @crgee. I've pushed a fix up to master to solve this. It will go out with the 1.0.3 release (no date set yet). In the meantime, you can point your Gemfile at master.

crgee commented 9 years ago

Great, thanks