search

jejacks0n / teaspoon

Teaspoon: Javascript test runner for Rails. Use Selenium, BrowserStack, or PhantomJS.
1.43k stars 243 forks source link

Returns 0 exit code if phantom fails to start #393

Closed statianzo closed 9 years ago

statianzo commented 9 years ago

When setting up CI, I was running teaspoon on a machine missing libfreetype, which phantom requires to run. This error was spit out to the console:

/home/runner/.phantomjs/1.9.8/x86_64-linux/bin/phantomjs: error while loading shared libraries: libfontconfig.so.1: cannot open shared object file: No such file or directory

Teaspoon still gave an exit code of 0 and my CI considered the build as a pass.

My desired behavior would be that phantom failing to start would give a non-zero exit code so that CI would've failed.

mikepack commented 9 years ago

Thanks a ton for submitting this issue, Jason. It should be resolved on master and will go out with the next release.