search

jejacks0n / teaspoon

Teaspoon: Javascript test runner for Rails. Use Selenium, BrowserStack, or PhantomJS.
1.43k stars 243 forks source link

Use jQuery instead of $ to check jQuery existence #422

Closed rafaelfranca closed 9 years ago

rafaelfranca commented 9 years ago

When jQuery.noConflict() is called the $ can be something different than jQuery like the webkit's default selector helper.

jejacks0n commented 9 years ago

This was technically to support some of the micro libraries that use $, but it's worth merging to see if it impacts anybody. Cheers!

rafaelfranca commented 9 years ago

I see. Maybe we can check the presence of parseHTML instead? My test suite is failing because parseHTML is undefined when $ is the browser selector helper.

jejacks0n commented 9 years ago

Nah, I think this is good. :+1:

rafaelfranca commented 9 years ago

Yeah, Zepto doesn't have parseHTML so it will fail anyway.