search

jejacks0n / teaspoon

Teaspoon: Javascript test runner for Rails. Use Selenium, BrowserStack, or PhantomJS.
1.43k stars 244 forks source link

Fix the usage of `time` in the junit formatter #455

Closed sguha00 closed 8 years ago

sguha00 commented 8 years ago

timestamp should be used to record when the test ran, time is the time taken to execute the tests

https://github.com/windyroad/JUnit-Schema/blob/master/JUnit.xsd#L195 - time https://github.com/windyroad/JUnit-Schema/blob/master/JUnit.xsd#L165 - timestamp

mikepack commented 8 years ago

Thanks!

sguha00 commented 8 years ago

Sorry, start is actually a String not a Time object. I made another pull request https://github.com/modeset/teaspoon/pull/456 to fix it