jejacks0n / teaspoon

Teaspoon: Javascript test runner for Rails. Use Selenium, BrowserStack, or PhantomJS.
1.43k stars 244 forks source link

Don't log error event to console #485

Closed bouk closed 7 years ago

bouk commented 8 years ago

Just ran into an interesting issue: because of same origin policies, javascript errors that get caught in onerror won't have an error message if they happen on a JavaScript file on a different domain.

I have modified the phantomjs onerror handler to log as "exception" instead of "error" when Teaspoon hasn't started yet, so it has the same effect as the onerror handler, just with more info available

bouk commented 8 years ago

for review @jejacks0n