Suite controller now returns correct status codes, and updated js to …

jejacks0n / teaspoon

Teaspoon: Javascript test runner for Rails. Use Selenium, BrowserStack, or PhantomJS.

1.43k stars 244 forks source link

Suite controller now returns correct status codes, and updated js to … #498

Closed ZackMattor closed 8 years ago

ZackMattor commented 8 years ago

…handle hook status codes.

Fixes #493

[x] Fix SuitesController so it doesn't always return a 500 status
[x] SuitesController should return a 200 on success, and a 404 when the hook can't be found.
[x] All hook xhr javascript should throw the error returned by the server

jejacks0n commented 8 years ago

:+1:

ZackMattor commented 8 years ago

There should probably be some tests around this... But that's all I can do today.

ZackMattor commented 8 years ago

@jejacks0n I think we should handle 500 errors better. Because currently it tries to parse them as json and throws a json parse error. I'll see if I can come up with a good way to handle that. Probably just

 if(xhr.status === 500) throw "Server returned a 500, check your hook's code."