search

jejacks0n / teaspoon

Teaspoon: Javascript test runner for Rails. Use Selenium, BrowserStack, or PhantomJS.
1.43k stars 243 forks source link

Support for webpacker #513

Closed mfazekas closed 1 year ago

mfazekas commented 7 years ago

Rails 5.1 will introduce webpacker see https://github.com/rails/webpacker.

The ideas is that it allows assets to be compiled by webpacker, but those have to be include by adding javascript_pack_tag

mfazekas commented 7 years ago

@jejacks0n any feedback on this?

I've tried to fix travis as well, fixed clode climate codecov and used webdrivers gem so it installs geckodriver, etc correctly.

mfazekas commented 7 years ago

@jejacks0n ping, rails 5.1 is out now

mfazekas commented 7 years ago

@jejacks0n any update on this?

jejacks0n commented 5 years ago

Alright, I tried to get this merged, but it's complicated and stale. I'm going to take what you've done here and commit it.. sorry!

jejacks0n commented 5 years ago

The code climate adjustments are where I had the most trouble. I know you were trying to be kind with that effort. =)

mfazekas commented 5 years ago

@jejacks0n no worries i'll try to rebase it.

mfazekas commented 5 years ago

@jejacks0n i've removed code climate changes. Only the ruby 2.5/rails 6 passes now.

Rails 5 test fails with You requested coverage reports, but no results were found. Are all files being ignored in your coverage config? If you have expand_assets set to false, you will need to remove spec_helper from the ignore list.

Do you have tips for that?

mathieujobin commented 3 years ago

rebased into e1c9097

anyone would wish to see this change being merged? please vote in