jejacks0n / teaspoon

Teaspoon: Javascript test runner for Rails. Use Selenium, BrowserStack, or PhantomJS.
1.43k stars 243 forks source link

Add support for 'skip_pipeline' asset option in Rails 5.1 #522

Closed daveallie closed 3 years ago

daveallie commented 7 years ago

skip_pipeline was not being passed through to path_to_javascript even though it's a valid option for Rails 5.1

This PR passes through skip_pipeline to path_to_javascript in Rails 5.1+

daveallie commented 6 years ago

@jejacks0n there appears to be a CI issue with deps, apart from that, these changes seem fine and are pretty low impact. Would you consider merging it?

ghiculescu commented 5 years ago

@jejacks0n are you open to merging this?

mathieujobin commented 3 years ago

the monkey patch has been removed in v1.2.2 this is no longer necessary