Jasmine client options - Githubissues

jejacks0n / teaspoon

Teaspoon: Javascript test runner for Rails. Use Selenium, BrowserStack, or PhantomJS.

1.43k stars 243 forks source link

Closed tilsammans closed 3 years ago

tilsammans commented 6 years ago

Continues #519

Thanks to everyone involved!

jsilvestri commented 6 years ago

@zzak, @tilsammans options[:client_driver_opts].symbolize_keys works as well and might address the syntax concerns here: https://github.com/jsilvestri/teaspoon/commit/7ec4b6d6e599cfe1a446ceea84a2e674550b0ca6

I have tested it with selenium-webdriver 3.8.0.

zzak commented 6 years ago

@jsilvestri I believe Hash#symbolize_keys is only available in ActiveSupport, but not sure that is a concern here.

jsilvestri commented 6 years ago

@zzak correct. Agreed it may not be ideal to depend on ActiveSupport.

mathieujobin commented 3 years ago

looks like #537 properly fix this issue, please reopen if you disagree