jejacks0n / teaspoon

Teaspoon: Javascript test runner for Rails. Use Selenium, BrowserStack, or PhantomJS.
1.43k stars 243 forks source link

Update changelog from last release #544

Closed aharpervc closed 3 years ago

aharpervc commented 6 years ago
aharpervc commented 6 years ago

@jejacks0n this is the same CI failure as the previous commit on master, so it doesn't appear to have been introduced by this branch. Also, I can't reproduce locally (all tests pass both on master and this branch).

Any idea what's going on?

Previous failure: https://travis-ci.org/jejacks0n/teaspoon/builds/399620721

twalpole commented 6 years ago

@aharpervc The failures are because the tests are using Capybara 3+ which defaults to using puma as the server. You either need to include puma in the project, specify Capybara.server = :webrick in the configuration or lock Capybara to < 3. If you update the project gems locally you should see the error locally too.

aharpervc commented 5 years ago

I suppose there's a question if this should be a major version change, since old Rails support was dropped. I'm neutral on this question, I just want the latest code via rubygems :)

twalpole commented 5 years ago

SemVer technically allows a package to change it's minimum requirements of other packages on a minor version - as long as code written to this packages API doesn't break - https://semver.org/#what-should-i-do-if-i-update-my-own-dependencies-without-changing-the-public-api. Of course that would mean specifying the new version requirements in the the gemspec.

jejacks0n commented 5 years ago

I think we should do a min version update at least, no?

aharpervc commented 5 years ago

I switched it to 1.2.0, although does that mean that mocha, qunit, and jasmine also need minor bumps? Probably not since that relationship is very flexible (>= 1.0.0)?