search

jejacks0n / teaspoon

Teaspoon: Javascript test runner for Rails. Use Selenium, BrowserStack, or PhantomJS.
1.43k stars 243 forks source link

Add Rails 6 (beta1) support #556

Closed KaanOzkan closed 5 years ago

KaanOzkan commented 5 years ago

Work in Progress PR opened to trigger CI and check for installation compatibilities. haml-rails is temporarily disabled for this WIP as the gem haven't released the latest Rails 6 support.

Includes a minor change to install_generator spec

KaanOzkan commented 5 years ago

Currently only failure is caused by disabling haml-rails in Rails 6. I will upgrade it once the new version is released.

Upgraded the ruby version to 2.5.0 as rails 6 requires 2.5.0 or newer.

jejacks0n commented 5 years ago

Thank you so much for this!

If haml is causing issues, let's remove it. If I recall, it's primarily there for a test that renders a haml fixture. Would this make your life easier?

jejacks0n commented 5 years ago

It looks good to me -- the failing test is the expected one that's using the haml rendering.

KaanOzkan commented 5 years ago

If you are okay with that it will be great. I can get rid of that test.

jejacks0n commented 5 years ago

If you are okay with that it will be great. I can get rid of that test.

Let's do it -- assuming there's a test for erb rendering logic. haha.

KaanOzkan commented 5 years ago

Hey Jeremy I just wanted to confirm since I am not familiar with this library. These fixture_spec.coffee tests seem to be failing for all of Jasmine 1,2 and Mocha. Were you thinking of removing those tests?

I was confused because those tests seemed to test fixtures in general and not haml rendering specifically. However, only way for me to get ✅ locally was by removing them (After removing fixture.html.haml)

jejacks0n commented 5 years ago

ah, so if you rename fixture.html.haml to fixture.html.erb (converting it in the process), those tests should pass again. What we want is for the fixture tests to remain, but for haml to no longer be required in those tests.

jejacks0n commented 5 years ago

I also need to get rid of the coffeescript stuff. So many things to do, so little time. Thanks for your help!

KaanOzkan commented 5 years ago

ah, so if you rename fixture.html.haml to fixture.html.erb (converting it in the process), those tests should pass again. What we want is for the fixture tests to remain, but for haml to no longer be required in those tests.

That makes more sense, thanks for clarifying 🙂

KaanOzkan commented 5 years ago

There seems to be a flaky test currently failing. https://travis-ci.org/jejacks0n/teaspoon/jobs/493976636 I don't think it is caused by my changes. Not sure if you want to investigate that right now or not.

jejacks0n commented 5 years ago

I looked at it, and yeah, can't tell.. will merge and find out. =)

Thanks again for this.

KaanOzkan commented 5 years ago

Thanks for maintaining the gem Jeremy.

This was my first open source contribution and appreciate the friendly experience :)

jejacks0n commented 5 years ago

That's awesome! I hope you go on to make a lot of open source contributions. 😄