jejacks0n / teaspoon

Teaspoon: Javascript test runner for Rails. Use Selenium, BrowserStack, or PhantomJS.
1.43k stars 243 forks source link

Add CI support for Sprockets 4 #573

Closed rossta closed 3 years ago

rossta commented 4 years ago

Additional Appraisal gemfiles are added to test against combinations of Rails 5 or Rails 6 with Sprockets 3 or 4. Also bumps Rails 5 and Rails 6 appraisals.

Thanks for maintaining this very useful gem!

rossta commented 4 years ago

@jejacks0n Any chance for a new release soon to support apps upgrading to Sprockets 4? Thanks!

thebravoman commented 4 years ago

I just open https://github.com/rails/sprockets/issues/650 because I tried to move to Sprocket 4. Hope this helps.

rossta commented 4 years ago

This might help: I had the same error when I upgraded my Rails app with teaspoon to Sprockets 4 and fixed the issue by pointing to teaspoon master:

gem 'teaspoon-jasmine', github: "jejacks0n/teaspoon"  

I use jasmine but it would be similar for teaspoon-qunit or teaspoon-mocha.

mathieujobin commented 4 years ago

please rebase and remove the duplicate files

squash into 1 commit

rossta commented 3 years ago

Better late than never? This PR is now rebased against the default branch.