jejacks0n / teaspoon

Teaspoon: Javascript test runner for Rails. Use Selenium, BrowserStack, or PhantomJS.
1.43k stars 243 forks source link

Fix coverage output path #579

Closed ukdave closed 3 years ago

ukdave commented 4 years ago

The output directory argument wasn't being passed to istanbul correctly causing the coverage report to always get generated in ./coverage/ instead of what had been configured in teaspoon.

I've updated the Open3.capture2e call in lib/teaspoon/coverage.rb to pass the argument names and values separately which fixes the issue.

mathieujobin commented 4 years ago

please merge good PRs like this one, so we can move forward.

I need teaspoon to work with latest selenium