Delay using Rails until loaded

jejacks0n / teaspoon

Teaspoon: Javascript test runner for Rails. Use Selenium, BrowserStack, or PhantomJS.

1.43k stars 243 forks source link

Delay using Rails until loaded #582

Closed eric-hemasystems closed 3 years ago

eric-hemasystems commented 4 years ago

When using ActionController, instrumentation should be used to wait until the component being used is fully loaded. Without this, it triggers the loading early through the autoloader which can lead to other problems.

For more background see rails/rails#36546.

jejacks0n commented 3 years ago

I’m am way overloaded with life things, so support whatever choices are best for everyone. Thank you @mathieujobin. 👍

On Mar 8, 2021, at 6:39 PM, Mathieu Jobin notifications@github.com wrote:

@mathieujobin approved this pull request.

seems to make sense

@jejacks0n opinion?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

mathieujobin commented 3 years ago

I vote we first enable tests to run on Github Actions #588 Then ask @eric-hemasystems to rebase this PR and merge it does not introduce problem. but it appears to be a good change to me