[ISSUE] HUD not working -- main UI freeze

[brunetton]

Describe the bug current dev branch (5d7a5f9eb6901e55d87d428f993168a5dac75c5c)

To Reproduce Steps to reproduce the behavior:

1. start HUD while playing poker
2. HUD window start
3. main window indicates that it found the corresponding hands history file
4. main window freezes

After a quick look it appears that ZMQ.send_string() is blocking; HUD UI never seems to receive the message

=> I'll take a moment to look deeper

[jejellyroll-fr]

i think ... i made a mistake between f9254dc786aa3efd58ab94730b997b6e224fcbe7 and de59665f575e527ebc86d885a0479e86736fb4c3

[brunetton]

i think ... i made a mistake between f9254dc and de59665

Looks like ;) I didn't looked deeper yet, too busy loosing a tournament :s

[jejellyroll-fr]

i find the issue ... i will make a PR ;)

[brunetton]

i find the issue ... i will make a PR ;)

Thanks for letting me know :)

[jejellyroll-fr]

I'll let you do the review ;) https://github.com/jejellyroll-fr/fpdb-3/pull/44

[brunetton]

I'll let you do the review ;) #44

Trop d'honneur :)

Would you hate me if I suggest really more atomic commits ?

[jejellyroll-fr]

Fais toi plaisir ;)

Le sam. 28 sept. 2024, 18:44, Bruno Duyé @.***> a écrit :

I'll let you do the review ;) #44 https://github.com/jejellyroll-fr/fpdb-3/pull/44

Trop d'honneur :)

Would you hate me if I suggest really more atomic commits https://dev.to/samuelfaure/how-atomic-git-commits-dramatically-increased-my-productivity-and-will-increase-yours-too-4a84 ?

— Reply to this email directly, view it on GitHub https://github.com/jejellyroll-fr/fpdb-3/issues/43#issuecomment-2380799539, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALNBS2IFXENHUP6CAL5ZUWDZY3MITAVCNFSM6AAAAABPAWB3E6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBQG44TSNJTHE . You are receiving this because you commented.Message ID: @.***>

[brunetton]

You merged it after asking me to review it :( I saw that it was already merged after reviewing it

[brunetton]

I rewrote your branch with spitted commits to show you what I meant by atomic commits; hope you don't mind I did ! I keep your author name of course

[brunetton]

But as you merged it (I didn't suspected it) it has been merges twice !

I you agree I can delete the first merge to have a clean history with only the second merge that correspond to the rewrited commit splitted in atomic commits:

• in green: original commit that contains multiple things that are not really related
• encircled in red (by myself): splitted commits

[jejellyroll-fr]

Oups I click too quick😅

Sure 🚀