search

jekirl / poketrainer

The original Pokemon Go bot
Other
119 stars 56 forks source link

Pokeballs instead of Ultra Balls #309

Closed filpet closed 8 years ago

filpet commented 8 years ago

While sniping, I just got this log:

2016-07-30 22:00:04,354 [ pgoapi] [ INFO] Teleporting to 47.074895, 15.444023 before catching 2016-07-30 22:00:06,798 [ pgoapi] [ INFO] Catching Pokemon: Type: Dragonite CP: 1445, IV: 75.56, Lvl: 15.0, LvlWild: 15.0, MaxCP: 99, Score: 1445, IV-Norm.: 70 2016-07-30 22:00:06,799 [ pgoapi] [ INFO] Attempting catch with POKE_BALL at 3.87% chance. Try Number: 1 2016-07-30 22:00:10,288 [ pgoapi] [ INFO] Attempting catch with POKE_BALL at 3.87% chance. Try Number: 2 2016-07-30 22:00:13,959 [ pgoapi] [ INFO] Attempting catch with POKE_BALL at 3.87% chance. Try Number: 3 2016-07-30 22:00:17,464 [ pgoapi] [ INFO] Feeding da razz berry! 2016-07-30 22:00:17,939 [ pgoapi] [ INFO] Attempting catch with POKE_BALL at 5.80% chance. Try Number: 4 2016-07-30 22:00:21,637 [ pgoapi] [ INFO] Feeding da razz berry! 2016-07-30 22:00:22,425 [ pgoapi] [ INFO] Attempting catch with POKE_BALL at 5.80% chance. Try Number: 5 2016-07-30 22:00:25,884 [ pgoapi] [ INFO] Feeding da razz berry! 2016-07-30 22:00:26,941 [ pgoapi] [ INFO] Attempting catch with POKE_BALL at 5.80% chance. Try Number: 6 2016-07-30 22:00:30,403 [ pgoapi] [ INFO] Feeding da razz berry! 2016-07-30 22:00:31,062 [ pgoapi] [ INFO] Attempting catch with POKE_BALL at 5.80% chance. Try Number: 7 2016-07-30 22:00:34,525 [ pgoapi] [ INFO] Feeding da razz berry! 2016-07-30 22:00:35,226 [ pgoapi] [ INFO] Attempting catch with POKE_BALL at 5.80% chance. Try Number: 8 2016-07-30 22:00:35,941 [ pgoapi] [ERROR] Error in pokemon encounter Lost remote after 10s heartbeat 2016-07-30 22:00:38,342 [ core] [ERROR]

Why is the bot using clearly ineffective Pokeballs again? I think this has been fixed in the past as far as I remember?

Thanks a lot!

jekirl commented 8 years ago

Pokeball usage needs to be made smarter, marking as enhancement

jekirl commented 8 years ago

Pushed a hacked together improvement to dev branch, will always try to use any ball that gets capture probability to at least 15% (should catch within 2-3 tries using perfect throws)

skydrome commented 8 years ago

@j-e-k why not simply use different balls based on cp? >800 throw greatball, >1200 throw ultraball? seems simple enough

jekirl commented 8 years ago

Well, that introduces the entire configuration debate that has been happening with transfers. Everyone cares about different stuff, CP/IV/LVL/Attacks/Rarity/Pokedex completion/etc...

jekirl commented 8 years ago

A ball with >15% capture probability should usually catch it in 1-3 tries.

rirze commented 8 years ago

Sorry, I don't know the api too well, but I've seen other bots use razz berries, curveballs, etc from the very start to achieve a certain target probability for capture. Is it possible to do the same thing with this project, maybe specify a capture probability percentage in the config and have the bot figure out what balls, or/and if berries and curveballs should be used?