Should this remain a fork?

[jekirl]

This bot has largely become its own project separate from tejado/pgoapi.

How do people feel about it remaining a fork? His is designed to be a low level api rather than a bot (like this)

👍 or 👎 and a reason why would really be appreciated so we can make an informed decision.

Thanks!

[Jay1]

Well I just came here today so my opinion weight less than others but I think this bot should wear his own name and split up from the fork yes. We will want to keep the API updated from upstream of course but now the bot is big enough to be a thing by itself.

:+1:

[beeedy]

Might be worth reaching out to ask him his thoughts, but this seems to have grown legs and really be its own thing.

[huntergregal]

This is using his core API, sure, but there have been others who have broken off the main fork with much less content then this. The flask integration and automation is in my opinion enough to justify breaking off. Of course I'd keep in kudos to tejado for the API base.

[jekirl]

Mentioning @tejado in the hopes he sees this

[Nemant]

I've been following this repo for a few days now and dug into most of the code. Definitely needs a major refactor as it's getting difficult to follow everything.

The easiest win would be to refactor everything belonging to the main loop into its own file and leaving everything from @tejado the way it is. Easier to sync with his updates :)

[joychugh]

@Nemant there was quite a lot of cleanup done if you see lot of methods have been broken down to small chunks and json is turned into objects. The eventual goal is to break it down to different modules. We are getting there, it takes time :)

[tejado]

Hey :) yes, pgoapi is more a library only. Most bots/projecs are based on it currently. As the project is already very big (in regards of open topics, issues, ...) every support/contribution is highly welcome. I would recommend you, to rename your (this) repo to a more unique name and also follow @Nemant suggestion. We don't know what Niantic will do in the future so we shouldn't maintain different small projects to communicate with their API but to have one stable codebase which can be the base of a lot of wonderful projects (like PokemonGo-Map, this repo etc...). If you did a lot of cleanup to your fork of pgoapi, it would be really awesome to push them back to me over pull requests - then it is easier for you to be just dependend on pgoapi (I have also releases, so... :)).

[bicheichane]

Today I wondered why this was a fork from tejado, as these are projects with different aims, one is an API and its aim is to stay as an API, while this project aims to be a fully grown bot, and has reached a size and visibility that is quite substantial in my view. And although it depends on the API by tejado, I don't think it makes sense to stay as a fork!

[jekirl]

Alright, will de-fork once I think of a name (any suggestions...???)

[Nemant]

PokeTrainer.io is available ;) https://www.name.com/domain/search/?domain=poketrainer.io&tld=io

[Jay1]

awesome name

[huntergregal]

Love it. Expensive TLD though

[beeedy]

poketrainer.io appears to be half the cost at godaddy. Not endorsing godaddy, but just saying it might be worth shopping around

[bicheichane]

I like PokeTrainer, seems nice and appropriate :+1:

[Jay1]

poketrainer.io is not really expensive on domain.com (better than godaddy if you ask me). I would be willing to pitch in some cash if you want.

[bicheichane]

Ehm, is a site dedicated to this really necessary now? Couldn't we just hang out here on github for the time being?

[Nemant]

It's just a name. The site can be a blank page or point to the GitHub repo. I prefer if we don't put anything on the website.

I personally don't want to be advertising this repo at all as it'll soon be full of abusers that'll ruin the game.

[beeedy]

@Nemant is right, if botting becomes too easy or prevalent the game will quickly be ruined for all

[joychugh]

AshKetchum :)

[jekirl]

Poketrainer it is

[tejado]

Niceee :)