search

jekyc / wig

WebApp Information Gatherer
BSD 2-Clause "Simplified" License
538 stars 141 forks source link

added fixes for the unusable strict parameters #18

Closed james-see closed 8 years ago

james-see commented 8 years ago

Only changed a few lines of code in discovery.py to fix the issues with the script failing on later versions of urllib and the unusable 'strict' parameter for the parse function. Tested and working.

jekyc commented 8 years ago

Hi,

Thanks for the pull request and identifying the issue! Unfortunately this will change wig's behavior when run under Python 3.2 as this version defaults to 'strict'=True (https://docs.python.org/3.2/library/html.parser.html). I think a check is needed for the current python version, so that the results aren't different on 3.2.

I've just committed a variation of your request - is it possible for you to test if this solves the issue you're seeing?

james-see commented 8 years ago

Sure I will check to make sure. Version checking is definitely optimal in this case, unless you want to force everyone to upgrade. ;)

On Nov 2, 2015, at 5:22 PM, jekyc notifications@github.com wrote:

Hi,

Thanks for the pull request and identifying the issue! Unfortunately this will change wig's behavior when run under Python 3.2 as this version defaults to 'strict'=True (https://docs.python.org/3.2/library/html.parser.html). I think a check is needed for the current python version, so that the results aren't different on 3.2.

I've just committed a variation of your request - is it possible for you to test if this solves the issue you're seeing?

— Reply to this email directly or view it on GitHub.

james-see commented 8 years ago

Works great! I will try to get rid of this pull request on my end. Thanks