search

jekyll / Utterson

CI benchmarking suite for Jekyll
MIT License
13 stars 8 forks source link

Polish Utterson's site #50

Closed ashmaroli closed 6 years ago

ashmaroli commented 6 years ago

Its not perfect, but its an improvement.. :wink:

report html

pathawks commented 6 years ago

I really like these changes.

Can we omit the <style>? I would really rather not maintain a stylesheet here; it would be nice if we could just use Jekyll's existing stylesheet for everything. How far can we get without using our own stylesheet?

ashmaroli commented 6 years ago

How far can we get without using our own stylesheet?

Not far enough, I'm afraid..

pathawks commented 6 years ago

Not far enough, I'm afraid..

So... I guess we won't be able to merge this?

ashmaroli commented 6 years ago

I guess we won't be able to merge this?

I'll try if I can "polish" without any CSS or close this myself..

ashmaroli commented 6 years ago

@pathawks This is the minimum CSS required for aesthetics. If that's unacceptable, you can close this PR.

pathawks commented 6 years ago

I don't really understand why we need our own CSS since we're not doing anything that the primary Jekyll site isn't already doing, but I do agree that this looks better :+1:

@DirtyF had an idea to create a Jekyll theme that could be shared among several of these offshoot Jekyll sites. I think that would be a great idea, and also probably a lot of work.

ashmaroli commented 6 years ago

We're not doing anything that the primary Jekyll site isn't already doing,

The difference here is lack of content. That warrants a thick header or a sticky footer, the latter of which hasn't been implemented at the primary site..

pathawks commented 6 years ago

You may have to flush your browser cache, but I rebuilt this page with the new layout: https://utterson.pathawks.com/markdown-converters.html

screenshot of new layout

ashmaroli commented 6 years ago

but I rebuilt this page with the new layout:

Whoa! why is the page in Portrait orientation? Is this a screen grab from an iPad?

pathawks commented 6 years ago

Whoa! why is the page in Portrait orientation? Is this a screen grab from an iPad?

This is my desktop. I cropped off the sides.

ashmaroli commented 6 years ago

I cropped off the sides.

I must apologize then. I had implemented the css at my 1366x768 resolution..

pathawks commented 6 years ago

I must apologize then.

It's better than before. We'll get this all sorted out if/when we make a unified Jekyll theme :+1:

pathawks commented 6 years ago

The homepage though... :rofl:

Utterson homepage with new layout

ashmaroli commented 6 years ago

Oh Good Lord!! Flexbox is a dangerous tool!! How does the page look when you serve the site locally without the internal css?

pathawks commented 6 years ago

no-css