search

jekyll / classifier-reborn

A general classifier module to allow Bayesian and other types of classifications. A fork of cardmagic/classifier.
https://jekyll.github.io/classifier-reborn/
GNU Lesser General Public License v2.1
554 stars 110 forks source link

Freeze all Ruby string literals #190

Closed ashmaroli closed 4 years ago

ashmaroli commented 4 years ago

To reduce their allocation on modern Rubies

ashmaroli commented 4 years ago

Required Ruby version should be 2.3+ then no?

Technically, older Ruby versions will consider the pragma to be just a regular comment. Since I'm not introducing any new Ruby 2.3+ syntax or method, I don't see the need to bump required Ruby version here.

Also, just to be sure, I'll open a separate PR that builds on CI with older Rubies..

mattr- commented 4 years ago

Let's just bump the gemspec. Everything older than 2.4 is EOL anyways.

DirtyF commented 4 years ago

@jekyllbot: merge +dev