search

jekyll / github-metadata

Jekyll plugin to propagate the `site.github` namespace and set default values for use with GitHub Pages.
https://jekyll.github.io/github-metadata/
MIT License
282 stars 127 forks source link

github_edit_link contains pagination path #213

Closed cmbuckley closed 2 years ago

cmbuckley commented 3 years ago

If a page is paginated: true, all pages (except the first) contain the paginate_path in the github_edit_link.

I created a minimal demo here, but if you have the following config:

repository: "owner/repo"
paginate_path: "page/:num/"

and an index.html with paginated: true, then when you visit /page/2/ the github_edit_link will contain /page/2/index.html instead of just /index.html.

The issue here would seem to come from jekyll-paginate, because the page.path is set to /page/2/index.html. It seemed better to raise the issue here since that repo is not maintained.

jekyllbot commented 3 years ago

This issue has been automatically marked as stale because it has not been commented on for at least two months.

The resources of the Jekyll team are limited, and so we are asking for your help.

If this is a bug and you can still reproduce this error on the master branch, please reply with all of the information you have about it in order to keep the issue open.

If this is a feature request, please consider whether it can be accomplished in another way. If it cannot, please elaborate on why it is core to this project and why you feel more than 80% of users would find this beneficial.

This issue will automatically be closed in two months if no further activity occurs. Thank you for all your contributions.

jekyllbot commented 2 years ago

This issue has been automatically marked as stale because it has not been commented on for at least two months.

The resources of the Jekyll team are limited, and so we are asking for your help.

If this is a bug and you can still reproduce this error on the master branch, please reply with all of the information you have about it in order to keep the issue open.

If this is a feature request, please consider whether it can be accomplished in another way. If it cannot, please elaborate on why it is core to this project and why you feel more than 80% of users would find this beneficial.

This issue will automatically be closed in two months if no further activity occurs. Thank you for all your contributions.