Get path for first page of paginated pages

jekyll / github-metadata

Jekyll plugin to propagate the `site.github` namespace and set default values for use with GitHub Pages.

https://jekyll.github.io/github-metadata/

MIT License

278 stars 125 forks source link

Get path for first page of paginated pages #219

Open cmbuckley opened 2 years ago

cmbuckley commented 2 years ago

When a page is paginated, the edit link includes the pagination part of the URL. This grabs the path from the first page of the pagination collection.

I would appreciate some help with the tests as I'm not familiar enough with Ruby.

Closes #213

ashmaroli commented 2 years ago

Okay. The existing tests pass. Therefore, no regressions. Now you need to add the test that proves this change works (with your use-case) as claimed.

cmbuckley commented 2 years ago

Hmm, not what I was expecting. Although I note that the tests are running against Jekyll 4.2.1 and I was using 3.9.0 to match the version in github-pages gem.

parkr commented 1 year ago

Seems like a useful bug fix.