Deprecate unnecessary constant in `GitHubMetadata::Client`

jekyll / github-metadata

Jekyll plugin to propagate the `site.github` namespace and set default values for use with GitHub Pages.

https://jekyll.github.io/github-metadata/

MIT License

282 stars 127 forks source link

Deprecate unnecessary constant in `GitHubMetadata::Client` #239

Closed ashmaroli closed 1 year ago

ashmaroli commented 2 years ago

I stumbled upon the realization that Faraday::ConnectionFailed is valid even in faraday-0.17 and older and that there is no need of testing for Faraday::Error::ConnectionFailed. The latter class is just an alias of the former.

Therefore, let us deprecate the GitHubMetadata::Client::FARADAY_FAILED_CONNECTION constant which should have ideally been a private_constant.

parkr commented 1 year ago

IIRC, this was for the Faraday 0.x to 1.0 migration.

parkr commented 1 year ago

@jekyllbot: merge +fix