search

jekyll / jekyll-admin

A Jekyll plugin that provides users with a traditional CMS-style graphical interface to author content and administer Jekyll sites.
https://jekyll.github.io/jekyll-admin/
MIT License
2.82k stars 357 forks source link

Add option to change homepage #617

Closed mertkahyaoglu closed 3 years ago

mertkahyaoglu commented 3 years ago

Closes #156

ashmaroli commented 3 years ago

What if the user would like to have the data or drafts route as their homepage?

mertkahyaoglu commented 3 years ago

@ashmaroli I didn't think anybody would want that 😅 We can add that but do you think that's a useful case?

ashmaroli commented 3 years ago

Since users are asking for the homepage to be something other the /pages/ route, I think it'd be best if user could choose whatever supported route to be their indexRoute..

mertkahyaoglu commented 3 years ago

@ashmaroli 👍 Added all other routes as well.

ashmaroli commented 3 years ago

The implementation LGTM! Does this need test coverage?

mertkahyaoglu commented 3 years ago

Absolutely but it's a bit tricky to test so I skipped it thinking code is safe. We'll see if we get any issue about this 😅