search

jekyll / jekyll-admin

A Jekyll plugin that provides users with a traditional CMS-style graphical interface to author content and administer Jekyll sites.
https://jekyll.github.io/jekyll-admin/
MIT License
2.82k stars 357 forks source link

Processes site when writing file #629

Closed coreycarvalho closed 1 year ago

coreycarvalho commented 3 years ago

This PR seeks to address https://github.com/jekyll/jekyll-admin/issues/623.

Resolved #623

Instead of reading the entire site, which could lead to duplicating files, I opted to just re-process the site.

coreycarvalho commented 3 years ago

Two tests break with Jekyll 4.2. Going to work on that and commit over the coming days.

Edit: Discovered the change that broke the test: https://github.com/jekyll/jekyll/pull/8497/files

Martfed commented 3 years ago

hi @coreycarvalho any news on this? If you need help I would be happy to do so

coreycarvalho commented 3 years ago

Hey @Martfed - I opened up https://github.com/jekyll/jekyll-admin/pull/631 to fix the failing tests. My plan was to rebase this PR onto the 631 once it gets approved and merged.

Martfed commented 3 years ago

Awesome, thank you!

coreycarvalho commented 1 year ago

@Martfed I amended my commit message to force the test suite to run again... it looks like jekyll-4.2.1 fixed the issue with the tests. If this passes, I'd love to get this merged in.

ashmaroli commented 1 year ago

Thanks @coreycarvalho