search

jekyll / jekyll-admin

A Jekyll plugin that provides users with a traditional CMS-style graphical interface to author content and administer Jekyll sites.
https://jekyll.github.io/jekyll-admin/
MIT License
2.82k stars 357 forks source link

Fixes broken tests from 4.2 #631

Closed coreycarvalho closed 1 year ago

coreycarvalho commented 3 years ago

This PR addresses https://github.com/jekyll/jekyll-admin/issues/630

The issue linked describes the issue.

For the apiable test, I opted to change the expected value to what liquid returns. This accounts for potential changes that Jekyll makes to the exact content returned.

For the page test, I opted to match against "Test Page", since we can reasonably expect that to be returned regardless of if Jekyll changes the exact values returned.

coreycarvalho commented 2 years ago

Anyone around to review this? 😬

ashmaroli commented 2 years ago

@coreycarvalho Thank you for your contribution. Unfortunately, I think this change is no longer necessary.

Could you try reproducing #630 with jekyll-4.2.1 at your end?

coreycarvalho commented 1 year ago

@ashmaroli hey - it looks like this issue is indeed fixed with jekyll-4.2.1