Add option to set admin specific scheme/host/port

jekyll / jekyll-admin

A Jekyll plugin that provides users with a traditional CMS-style graphical interface to author content and administer Jekyll sites.

https://jekyll.github.io/jekyll-admin/

MIT License

2.82k stars 357 forks source link

Add option to set admin specific scheme/host/port #684

Open CGillen opened 2 years ago

CGillen commented 2 years ago

Fixes #610 @ashmaroli mentioned they wanted tests on the fix. These might not be the best tests, so if you have any suggestions I'll gladly fix them up.

ashmaroli commented 2 years ago

@CGillen Thank you for proposing an enhancement.

From a quick glance, it looks like you're assuming site.config["jekyll_admin"] will always be defined. What if it isn't?

CGillen commented 2 years ago

#dig would be a better solution, wouldn't it? Doubtful site.config["jekyll_admin"] would be defined as anything besides a hash.