Closed rpeyron closed 1 year ago
Thank you for submitting this pull request, @rpeyron.
Leaving a few points as feedback:
do_process
isn't fully transparent to the underlying implementation. How about conditionally_process_site
? That way, a future contributor (including us) will know what to expect immediately on reading the code.site.config["watch"]
(without actually loading Jekyll's Watcher). I haven't tested this; just a hypothesis. The solution for this could be initializing a new object (e.g. JekyllAdmin.site_processor
). If this is too confusing for you, let me know. I will make that change in a separate pull request / commit.Hello @ashmaroli ; thanks for your feedback
Thank you @rpeyron
Fix mentioned in #699
Will avoid duplicate site processing: either we are in watch mode and jekyll-admin do not need to trigger site.process, or we are not in watch mode and jekyll-admin will trigger site.process
Note that it does not work when using
--livereload --no-watch
options simultaneously, which has little interest, as livereload option will forceconfig{"watch"]=1
.Closes #699