search

jekyll / jekyll-archives

:books: Archive pages for your Jekyll tags and categories.
https://jekyll.github.io/jekyll-archives/
MIT License
436 stars 99 forks source link

Add .html to archive file names without extension #127

Closed Exagone313 closed 3 years ago

Exagone313 commented 6 years ago

Fixes #102.

Read carefully before merging, this may break some configurations, I need your feedback. Also this is the first time I'm writing Ruby.

Exagone313 commented 6 years ago

Hmm, the commit message may not be good as I'm checking for \.html$ and not if there isn't an extension.

ashmaroli commented 5 years ago

@Exagone313 Are you still interested in getting this merged..?

Exagone313 commented 5 years ago

It requires some changes but I still want to fix the underlying issue I created.

ashmaroli commented 5 years ago

Okay. Apart from amending the original commit message (git commit --amend), you may want to check the source code for Jekyll::Page#destination and Jekyll::Document#destination for logic reference.

Exagone313 commented 3 years ago

I don't have time to work on this PR, I'm closing it.