Added the "slug_mode" option to URL generation.

[cosmochefe]

This commit helps with localization of URLs for sites that use category and tag names that have accented characters. By using the "slug_mode" option in the site's configuration file, the user can apply the correspondent mode of the "Utils.slugify" method to the generated directory name and URL. Issue #121 should be resolved by this.

[ashmaroli]

@cosmochefe Thank you for the contribution. I'm on board with the proposal. But this needs a test to see if a scenario similar to #121 is resolved and stays so, with some test coverage.

[ashmaroli]

Related: #100

[ashmaroli]

Prior art: #129

[cosmochefe]

Hi Ashwin, how are you?

This is the very first time I contribute to a project on GitHub. Is there a source of information so I can understand what to do next? Should I just write a test inside the homonymous directory or should I do something else?

Thank you in advance. Cheers!

Em 12 de abr de 2020, à(s) 03:17, Ashwin Maroli notifications@github.com escreveu:

@cosmochefe Thank you for the contribution. I'm on board with the proposal. But this needs a test to see if a scenario similar to #121 is resolved and stays so, with some test coverage.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

[ashmaroli]

I'm fine Alvaro, thank you. Hope you're doing great as well. Thanks for letting me know this is is your first GitHub contribution ever. I'll provide you with some orientation:

• Ideally, a GitHub project would have a CONTRIBUTING.md or similar document that explains what to do when contributing to a project. But not every project has that document.
• In a situation where the project repository doesn't have strict guidelines, you just submit a pull request and wait for the project's maintainer(s) to leave a review and then proceed to do as requested in the review.
• It is considered good practice to:
  • propose related changes yet narrow down the scope as much as possible.
  • have commit message(s) that are of 50 characters or lesser and best describe the contained changes.
  • open the pull request with an appropriate title and description
  • if the repository has a pull request template, always best to follow along with it.
  • accompany at least one test related to the proposed change so that everyone can instantly gauge what the expected behavior is. Additionally, tests ensure that a future change doesn't break your expectations.
  • where requested, accompany appropriate documentation so that users know how to employ the feature you have proposed.

---

Regarding your proposal, unfortunately, there's already a prior submission (#129). You can get an idea about testing by viewing that PR — basically add a post with accented characters in the title and assert that the end-result is what you expect to get.

I've left a message to the original author to revisit their submission. If that PR gets dropped, this pull request will get picked up. If it doesn't, well.. this could be an exercise for you....

[ashmaroli]

Superseded by prior submission #129