Allow use and testing with Jekyll 4.0

jekyll / jekyll-avatar

A Jekyll plugin for rendering GitHub avatars

MIT License

89 stars 9 forks source link

Closed ashmaroli closed 5 years ago

ashmaroli commented 5 years ago

Jekyll 4.0 is on the horizon..

welcome[bot] commented 5 years ago

Welcome! Congrats on your first pull request to Jekyll Avatar. If you haven't already, please be sure to check out the contributing guidelines.

ashmaroli commented 5 years ago

@benbalter I didn't realize all these tasks would be within the scope of this one pull request. Sorry for the trouble..

benbalter commented 5 years ago

I didn't realize all these tasks would be within the scope of this one pull request. Sorry for the trouble..

That's how things always seem to go! :smile: Really appreciate the PR. Thanks!

benbalter commented 5 years ago

@ashmaroli Would love to get this merged if you have a spare cycle to resolve the Rubocop issue, if not, no worries. Appreciate the PR!

ashmaroli commented 5 years ago

if you have a spare cycle to resolve the Rubocop issue,

I'll look into it. No issues..

ashmaroli commented 5 years ago

Requires #33..

ashmaroli commented 5 years ago

I recommend a squash-merge on this one. Too many back-n-forth commits..

benbalter commented 5 years ago

Thanks again @ashmaroli!

ashmaroli commented 5 years ago

You're welcome @benbalter :smile:

ashmaroli commented 4 years ago

@benbalter Jekyll 4.0 is around the corner. Hope you can a cut a release to ship support for Jekyll 4.0 soon. Thanks.